-
Notifications
You must be signed in to change notification settings - Fork 929
docs: describe our telemetry #2641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ammario I think this all makes sense and I agree with/like the approach. Other OSS has set the precedent of not having what you describe as level 0
ie you can't disable telemetry; but you can set it to an anonymized setting aka level 1
. So I think the decision we have is whether we want to include level 0
in Enterprise or forego level 0
altogether.
I think having the ability to opt out entirely (even if it is only for Enterprise customers) is a good move. But I'm curious to see what others think.
@tjcran thanks for the review. For our customer base level 0 will be necessary. Perhaps it won't be default in the enterprise plan, but it will certainly be requested often. |
@tjcran someone will need someone to build out the feature before I can merge this. I think that should be really easy though, as we just need to add email addresses and then the environment variable parsing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think options 1 and 2 should have some sort of mention of the data we do collect. So like "this level collects product usage patterns, email and IP. This one only collect product usage patterns. This one collects nothing. " We can be vague here, but I was confused on the difference between 1 and 0 because it reads like we only collect email and IP.
Love the overall message and rationale here ❤️ |
Well, weren't we making it required? I think of this doc as kind of a commitment to the community so would rather merge it after we have these uncertainties worked out. |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
fc2c63c
to
01c9735
Compare
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity. |
Co-authored-by: Ben Potter <ben@coder.com>
6d8b708
to
012c2d0
Compare
This PR proposes features that do not yet exist. I figured we could use this PR as both production documentation and an RFC.