Skip to content

fix: consistent workspace status b/w CLI and UI #2743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 1, 2022
Merged

fix: consistent workspace status b/w CLI and UI #2743

merged 2 commits into from
Jul 1, 2022

Conversation

AbhineetJain
Copy link
Contributor

This PR uses the same logic to show workspace status in CLI as the one used in UI.

Subtasks

  • add a util method to compute workspace status and use it
  • add unit tests

Fixes #2717

@AbhineetJain AbhineetJain requested a review from a team June 30, 2022 00:06
johnstcn
johnstcn reviewed Jun 30, 2022
View reviewed changes
cli/workspacestatus_internal_test.go Outdated
}
})
}
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

praise: nice test!

Emyrk
Emyrk reviewed Jun 30, 2022
View reviewed changes
@AbhineetJain AbhineetJain force-pushed the abhineetjain/2717-workspace-status-cli branch from 107f412 to 6e6b7a3 Compare July 1, 2022 07:18
@AbhineetJain AbhineetJain force-pushed the abhineetjain/2717-workspace-status-cli branch from 6e6b7a3 to 28d0f4c Compare July 1, 2022 07:22
@AbhineetJain AbhineetJain mentioned this pull request Jul 1, 2022
Closed
@AbhineetJain AbhineetJain requested review from johnstcn and Emyrk July 1, 2022 07:29
Emyrk
Emyrk approved these changes Jul 1, 2022
View reviewed changes
@AbhineetJain AbhineetJain enabled auto-merge (squash) July 1, 2022 14:34
@AbhineetJain AbhineetJain merged commit de1fc40 into main Jul 1, 2022
@AbhineetJain AbhineetJain deleted the abhineetjain/2717-workspace-status-cli branch July 1, 2022 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

@Emyrk Emyrk Emyrk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CLI displays workspace status as Running when Start was canceled and it was not started
3 participants
@AbhineetJain @johnstcn @Emyrk