feat: add verbose error messaging #3053
Conversation
There was a problem hiding this comment.
Other than the checkVersions function that could do with a cleanup, this looks great!
The only thing I noticed isn't touched by this PR, so not exactly relevant, but documenting it anyhow:
We probably shouldn't output the version check error when we can't reach the API as it adds verbosity to the output:
|
|
||
| _, _ = fmt.Fprint(&output, helpErrMsg) | ||
|
|
||
| return cliui.Styles.Error.Render(output.String()) | ||
| } | ||
|
|
||
| func checkVersions(cmd *cobra.Command, client *codersdk.Client) error { |
There was a problem hiding this comment.
Happened to notice this function still uses hard-coded version of varNoVersionCheck and also has a suppression check (which we're doing in the pre-run as well), do we want to keep both?
There was a problem hiding this comment.
Good catch, we don't need to keep both checks but I kept the check at the top of the the pre-run to avoid the unnecessary I/O of instantiating a client that we immediately throw away when someone passes the disable-warning flag.
Great point I'll open up another PR to clean up some of that noise |
loginfatally errored when checking versions.Regular output:
Verbose output: