fix: handle workspace errors #3341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presleyp
approved these changes
Aug 1, 2022
kylecarbs
approved these changes
Aug 1, 2022
|
@presleyp I published the stories manually here: https://624de63c6aacee003aa84340-uboeickwbe.chromatic.com/?path=/story/components-workspace--error |
|
Storybook makes it look like we're displaying an error message when a build is successfully canceled - is it supposed to be an error saying it failed to cancel? Or a success message about cancellation? |
AbhineetJain
commented
Aug 1, 2022
presleyp
approved these changes
Aug 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR handles the errors shown on the Workspace (singular) page. We handle the following types of errors:
Subtasks
ErrorSummarycomponent for the listed errorsFixes #3094
Screenshots
get resources
get builds
build cancellation
build error
get workspace