docs: update CONTRIBUTING requirements #3541
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Aug 17, 2022
docs/CONTRIBUTING.md
Outdated
Comment on lines
11
to
13
| - [`zstd`](https://github.com/horta/zstd.install) | ||
| - [`pg_dump`] | ||
| - on macOS, run `brew install libpq zstd` |
There was a problem hiding this comment.
I wasn't sure if this would confuse people since I technically list zstd twice, but also because I put pg_dump but then tell people to install libpq and zstd. Open to better ideas!
There was a problem hiding this comment.
We could break out into separate Linux and MacOS sections, perhaps?
There was a problem hiding this comment.
Good idea! I went with this for now: 6aa9e83
jsjoeio
commented
Aug 18, 2022
johnstcn
approved these changes
Aug 18, 2022
|
Looks like I need a ✅ from @ammario before I can merge. |
johnstcn
approved these changes
Aug 18, 2022
ammario
approved these changes
Aug 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2739 and also removes
devscript fromMakefile