Skip to content

fix: Shadow err in TestProvision_Cancel to fix test race #3579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2022
Merged

fix: Shadow err in TestProvision_Cancel to fix test race #3579

merged 1 commit into from
Aug 19, 2022

Conversation

mafredri
Copy link
Member

Fixes #3574

@mafredri mafredri self-assigned this Aug 19, 2022
@mafredri mafredri requested a review from a team August 19, 2022 08:13
johnstcn
johnstcn approved these changes Aug 19, 2022
View reviewed changes
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The Shadow" strikes again 🥷

@mafredri mafredri merged commit 3fdae47 into main Aug 19, 2022
@mafredri mafredri deleted the mafredri/fix-test-bug branch August 19, 2022 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnstcn johnstcn johnstcn approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

data race in terraform/provision_test.go:103
2 participants
@mafredri @johnstcn