Skip to content

fix: template: enforce bounds of template max_ttl #3662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 24, 2022
Merged

fix: template: enforce bounds of template max_ttl #3662

merged 8 commits into from
Aug 24, 2022

Conversation

johnstcn
Copy link
Member

@johnstcn johnstcn commented Aug 24, 2022 •
edited
Loading

This PR makes the following changes:

  • enforces lower and upper limits on template max_ttl_ms
  • adds a migration to enforce 7-day cap on max_ttl
  • allows setting template max_ttl to 0
  • updates template edit CLI help to be clearer

Partially fixes #3640

@johnstcn johnstcn requested review from a team and Kira-Pilot August 24, 2022 12:43
johnstcn
johnstcn commented Aug 24, 2022
View reviewed changes
Emyrk
Emyrk approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Kira-Pilot
Kira-Pilot approved these changes Aug 24, 2022
View reviewed changes
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay!

@johnstcn johnstcn merged commit eba753b into main Aug 24, 2022
@johnstcn johnstcn deleted the cj/gh-3640/template-max-ttl-bounds branch August 24, 2022 14:45
@matifali
Copy link
Member

What does setting max_ttl to 0 mean? Turning off auto stop?

@johnstcn
Copy link
Member Author

johnstcn commented Aug 24, 2022 •
edited
Loading

What does setting max_ttl to 0 mean? Turning off auto stop?

Autostop can be enabled or disabled on a per-workspace basis. max_ttl controls the maximum workspace lifetime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emyrk Emyrk Emyrk approved these changes

@deansheather deansheather deansheather approved these changes

@Kira-Pilot Kira-Pilot Kira-Pilot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: template settings
5 participants
@johnstcn @matifali @Emyrk @deansheather @Kira-Pilot