Create winget-submission.yml #3729

matifali · 2022-08-29T14:55:23Z

This PR adds a GitHub action to publish every release to winget

Subtasks

packageFileName: coder_${VERSION}_windows_amd64.zip # Need to get VERSION from latest release to use here
packageId: MyPackageIdInWinget # Need to ge an official Winget Package ID
secrets.Project_PAT # generate a PAT with the scope public_repo and add it to your project's secrets with the name Project_PAT.
Resolve wingetcreate issue with portable apps.

Partially resolves #3714

packageFileName: coder_${VERSION}_windows_amd64.zip # Need to get VERSION from latest release to use here packageId: MyPackageIdInWinget # Need to ge an official Winget Package ID ecrets.Project_PAT # generate a PAT with the scope public_repo and add it to the secrets of your project with the name Project_PAT

matifali · 2022-08-29T15:08:43Z

Can you take a look at this? @bpmct

bpmct · 2022-09-09T12:33:48Z

Hey! Sorry for the late response - I'm looking at publishing the first package now so we can get the ID and then update via this action

matifali · 2022-09-09T13:23:40Z

Hey! Sorry for the late response - I'm looking at publishing the first package now so we can get the ID and then update via this action

Sure, link it here when you are done.

bpmct · 2022-09-09T13:31:44Z

@matifali It seems like Winget very recently added support for portable apps (standalone .exe) and it's somewhat new and experimental. For example, I can't figure out how to create the app with wingetcreate https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip as it's expecting a MSI file or similar, not a standalone exe.

Ah, I just saw this in the v1.3 release.

Note: The Windows Package Manager Community Repository does not accept portable applications. They will not be accepted until after 1.3 is Generally Available and has been rolled out to the majority of Windows systems via the automatic upgrade from the Microsoft Store. Users may test with local manifests.

I also haven't been able to test with a local manifest. This does not seem to be working for me. Any ideas?

# turn on install from file
winget settings --enable LocalManifestFiles

# install
winget install -m coder.yaml

Id: Coder.Coder
Name: Coder
Description: Remote development environments on your infrastructure provisioned with Terraform
Version: 0.8.14
Publisher: Coder
License: AGPL-3.0, Unknown licenses found
Homepage: https://github.com/coder/coder
Tags: portable
Installers:  
  - Arch: x64
    InstallerType: exe
    Url: https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip
    Sha256: 435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8

matifali · 2022-09-09T22:05:35Z

By modifying the manifest file as per the latest singelton schema, although for community repo submission, we need three files schemas (wingetcreate will generate them automatically)

PackageIdentifier: Coder.Coder
PackageVersion: 0.8.14
PackageLocale: en-US
Publisher: Coder
PackageName: Coder
License: AGPL-3.0, Unknown licenses found
ShortDescription: Remote development environments on your infrastructure provisioned with Terraform
Installers:
 - Architecture: x64
   InstallerType: portable
   InstallerLocale: en-US
   Commands: [coder]
   InstallerUrl: https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip
   InstallerSha256: 435cc6a195c7af4a210d90ed78f59f802407caf6740986087f4e2ae983b7d3f8
   InstallModes:
    - silent
ManifestType: singleton
ManifestVersion: 1.2.0

I was able to install it locally and reached up to this point.

PS C:\Users\matif> winget install -m coder.yaml
Found Coder [Coder.Coder] Version 0.8.14
This application is licensed to you by its owner.
Microsoft is not responsible for, nor does it grant any licenses to, third-party packages.
Downloading https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip
  ██████████████████████████████   112 MB /  112 MB
Successfully verified installer hash
Starting package install...
Overwriting existing file: C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder_0.8.14_windows_amd64.exe
Successfully installed

PS C:\Users\matif> coder
ResourceUnavailable: Program 'coder.exe' failed to run: An error occurred trying to start process 'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory 'C:\Users\matif'. The specified executable is not a valid application for this OS platform.At line:1 char:1
+ coder
+ ~~~~~.

matifali · 2022-09-09T22:26:23Z

@bpmct

For example, I can't figure out how to create the app with wingetcreate https://github.com/coder/coder/releases/download/v0.8.14/coder_0.8.14_windows_amd64.zip as it's expecting an MSI file or similar, not a standalone exe.

wingetcreate 1.1.2.0 does support creating manifests for portable apps, but I am not sure if it accepts a zip instead of an exe
May be coder should publish .exe for windows instead of .zip

There seems to be a known bug microsoft/winget-create#302 for why this is not working.

bpmct · 2022-09-19T18:22:40Z

Hmm ok. I will follow the issue there. It seems like this doesn't work with exe either, given that issue and the fact that it unzipped things fine

bpmct · 2022-09-19T18:23:50Z

ResourceUnavailable: Program 'coder.exe' failed to run: An error occurred trying to start process 'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory 'C:\Users\matif'. The specified executable is not a valid application for this OS platform.At line:1 char:1

How to we get past this? I ran into the same thing and it seems to be exclusive to winget

matifali · 2022-09-20T04:24:44Z

ResourceUnavailable: Program 'coder.exe' failed to run: An error occurred trying to start process 'C:\Users\matif\AppData\Local\Microsoft\WinGet\Links\coder.exe' with working directory 'C:\Users\matif'. The specified executable is not a valid application for this OS platform.At line:1 char:1

How to we get past this? I ran into the same thing and it seems to be exclusive to winget

Yes, it seems like it is installing it, and binary is on the path but can't execute. I will try to find the reason soon. It has to do something with 'App Execution Alias'.

matifali · 2022-09-23T07:18:25Z

https://github.com/microsoft/winget-pkgs/tree/master/manifests/r/RussellBanks/winfetch/2.4.1
Check this for reference. This is a portable app published on winget. It is using YamlCreate.ps1 to generate manifests.

github-actions · 2022-10-01T00:19:35Z

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

deansheather · 2022-10-25T15:47:36Z

Now that we have the installer this can be reopened and updated. The installer URL should be the asset URL from the release (e.g. https://github.com/coder/coder/releases/download/v0.11.0/coder_0.11.0_windows_amd64_installer.exe) and should have the same fields as the package I submitted manually: microsoft/winget-pkgs#86238

deansheather · 2022-10-25T15:51:17Z

.github/workflows/winget-submission.yml

+env:
+  version: "$(git describe --tags --abbrev=0)"
+  packageFileName: coder_${version}_windows_amd64.zip
+  packageId: Coder.Coder  # Most probably the id of coder package


These env vars should be in UPPER_SNAKE_CASE format like normal env vars, and should be referenced by "$NAME" in the script below instead of using ${env:NAME} as they have different semantics

deansheather · 2022-10-25T15:53:32Z

.github/workflows/winget-submission.yml

+    types: [published]
+
+env:
+  version: "$(git describe --tags --abbrev=0)"


For consistency we should stick to ./scripts/version.sh. Also, instead of having an evaluated statement here (which doesn't get evaluated instantly), you should just have these be variables in the script instead.

.github/workflows/winget-submission.yml

deansheather · 2022-10-25T15:54:14Z

.github/workflows/winget-submission.yml

@@ -0,0 +1,23 @@
+name: Submit package to Windows Package Manager Community Repository 


Could just be called submit-packages.yml and "Submit packages" so we can use it for other package managers in the future

matifali marked this pull request as ready for review August 29, 2022 15:07

matifali marked this pull request as draft August 29, 2022 15:07

added version from laest tag

2f31ba4

matifali marked this pull request as ready for review September 8, 2022 08:55

Added winget package id

68e9437

github-actions bot added the stale This issue is like stale bread. label Oct 1, 2022

github-actions bot closed this Oct 5, 2022

matifali mentioned this pull request Oct 25, 2022

feat: add windows amd64 installer #4719

Merged

deansheather reviewed Oct 25, 2022

View reviewed changes

ghuntley mentioned this pull request Nov 14, 2022

Paid Open-Source Bounties #5054

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create winget-submission.yml #3729

Create winget-submission.yml #3729

matifali commented Aug 29, 2022 •

edited

Loading

matifali commented Aug 29, 2022

bpmct commented Sep 9, 2022

matifali commented Sep 9, 2022

bpmct commented Sep 9, 2022 •

edited

Loading

matifali commented Sep 9, 2022 •

edited

Loading

matifali commented Sep 9, 2022 •

edited

Loading

bpmct commented Sep 19, 2022

bpmct commented Sep 19, 2022 •

edited

Loading

matifali commented Sep 20, 2022 •

edited

Loading

matifali commented Sep 23, 2022 •

edited

Loading

github-actions bot commented Oct 1, 2022

deansheather commented Oct 25, 2022

deansheather Oct 25, 2022

deansheather Oct 25, 2022

deansheather Oct 25, 2022

		@@ -0,0 +1,23 @@
		name: Submit package to Windows Package Manager Community Repository

Create winget-submission.yml #3729

Create winget-submission.yml #3729

Conversation

matifali commented Aug 29, 2022 • edited Loading

Subtasks

matifali commented Aug 29, 2022

bpmct commented Sep 9, 2022

matifali commented Sep 9, 2022

bpmct commented Sep 9, 2022 • edited Loading

matifali commented Sep 9, 2022 • edited Loading

matifali commented Sep 9, 2022 • edited Loading

bpmct commented Sep 19, 2022

bpmct commented Sep 19, 2022 • edited Loading

matifali commented Sep 20, 2022 • edited Loading

matifali commented Sep 23, 2022 • edited Loading

github-actions bot commented Oct 1, 2022

deansheather commented Oct 25, 2022

deansheather Oct 25, 2022

Choose a reason for hiding this comment

deansheather Oct 25, 2022

Choose a reason for hiding this comment

deansheather Oct 25, 2022

Choose a reason for hiding this comment

matifali commented Aug 29, 2022 •

edited

Loading

bpmct commented Sep 9, 2022 •

edited

Loading

matifali commented Sep 9, 2022 •

edited

Loading

matifali commented Sep 9, 2022 •

edited

Loading

bpmct commented Sep 19, 2022 •

edited

Loading

matifali commented Sep 20, 2022 •

edited

Loading

matifali commented Sep 23, 2022 •

edited

Loading