-
Notifications
You must be signed in to change notification settings - Fork 874
feat: add windows amd64 installer #4719
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Does the user need to sign out and sign in for the |
@kylecarbs It's the easiest way to get PATH updates to apply without having to run crazy commands to force refresh the PATH variable AFAIK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
Could you adjust this in the README? https://github.com/coder/coder#getting-started
Add under:
The easiest way to install Coder is to use our [install script](https://github.com/coder/coder/blob/main/install.sh) for Linux and macOS. For Windows, use our [installer](<link to latest release installer bin here>).
@kylecarbs there's no permalink for the installer, so I put the following in the README instead:
|
@deansheather hmm, that makes sense to me. link to the latest release too! Thoughts on this? https://stackoverflow.com/questions/6979741/setting-environment-variables-requires-reboot-on-64-bit btw this isn't blocking, just cool if it's easy to do |
@deansheather can we include the version somewhere in the installer UI? Might be helpful for folks |
Also, it will allow publishing on |
yep @matifali this is a follow up I'd like to do after merge :D |
Adds a Windows amd64 installer (built on Linux) using
makensis
. NSIS is an alternative to MSI which can easily be built on platforms other than Windows, and is used by well-known apps such as VLC and VirtualBox.Drops the following files in
C:\Program Files\Coder
:bin/coder.exe
uninstaller.exe
license.txt
Optionally adds
bin
to PATH. Registers Coder as an app in Windows settings so users can easily uninstall it.coder_0.10.2-devel+bf3224e3_windows_amd64_installer_NnWUVJKzWY.mp4