refactor: use WidgetsIcon for null resources #3754
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
presleyp
approved these changes
Aug 30, 2022
|
NICE! 👍🏼 |
|
@jsjoeio is the unknown resource still a
Edit: answered my own question, I think we should changed this to the widget icon too |
|
resolves #3301 |
Nice catch! I'll update that now then re-request a review. |
jsjoeio
commented
Aug 30, 2022
| // this resource can return undefined | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition | ||
| const IconComponent = iconByResource[type] ?? HelpIcon | ||
| const IconComponent = iconByResource[type] ?? WidgetsIcon |
There was a problem hiding this comment.
Since the resource can be undefined, I modified the return type of iconByResource to match that, which lets us remove this eslint line.
bpmct
approved these changes
Aug 30, 2022
728ceeb to
459cbd9
Compare
Based on user feedback, we believe the `WidgetsIcon` will cause less confusion.
Before, we were using `string` for `type` in `ResourceAvatar`. This meant it wasn't tied to the types generated from the backend. Now it imports `WorkspaceResource` so that there is a single source of truth and they always stay in sync.
459cbd9 to
6716acc
Compare
3 tasks
presleyp
approved these changes
Aug 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the icon used for null resources
Previous icon used:
h/t to @kconley-sq for the suggestion! 🎉
Also found another issue which I will tackle after this: #3767