chore: update cSpell, fix isNotificationTextPrefixed, and refactor e2e tests #4076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Sep 15, 2022
This removes an eslint-disable rule and adds two new tests to ensure isNotificationTextPrefixed is working as expected.
f5b13fc to
e6a5499
Compare
presleyp
previously approved these changes
Sep 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a few minor changes to
cSpellsettings for VS Code and a couple minor improvements forisNotificationTextPrefixed.Changes
Important
I also removed the
util.tswhich had some things likewaitForClientSideNavigation. I don't think this is needed anymore after reading the Playwright docs (maybe a new thing):Source
This should speed up the e2e tests too.