refactor: add type safety in utils.test.ts #4091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes a few changes to the typings in site/src/components/GlobalSnackbar/utils.test.ts to more accurately represent the types we're using. It allows us to remove from type assertion and one eslin-disable comment..
jsjoeio
commented
Sep 16, 2022
| } | ||
|
|
||
| beforeEach(() => { | ||
| dispatchEventMock = jest.fn() | ||
| window.dispatchEvent = dispatchEventMock | ||
| window.dispatchEvent = dispatchEventMock as unknown as typeof window.dispatchEvent |
There was a problem hiding this comment.
I think this is the only way to properly type this:
as unknown"Don't worry, I'm casting my thingunknowntype before my assertion"as typeof window.dispatchEvent"This is what it actually is"
code-asher
approved these changes
Sep 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a few changes to the typings in
site/src/components/GlobalSnackbar/utils.test.tsto more accuratelyrepresent the types we're using. It allows us to remove from type
assertion and one eslint-disable comment.