chore(site): fix material ui warning #4161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the latest version which includes a fix for the warning we were seeing while running our tests about `css` function being deprecated.
`fade()` was deprecated in favor of `alpha()` in a previous version of `@material-ui/core/styles`.
This was deprecated in a previous version of `@material-ui/core`.
overlap="circle" was deprecated in favor of overlap="circular".
This was deprecated and changed to `createTheme`.
Kira-Pilot
approved these changes
Sep 22, 2022
|
Looks like there are some other changes I missed. Adding those now. |
I couldn't find any release notes or breaking changes related to this but it seems `props` can no longer be inferred on `SvgIcon`s so I had to manually add the type.
|
I'm not seeing these same errors locally when I run |
|
Hmm possibly a showstopper if this is true: mui/material-ui#33216 (comment) |
This reverts commit 94dae6f.
Unfortunately it looks stale. |
|
Nevermind, I figured it out. Had to use generics in |
Looks like we may need to pass an empty object if some components in a file use `props` in styles and some don't.
We need to use generics so that `makeStyles` correctly infers the types for the `Pill.tsx` styles. I also updated the types to use `PillProps` directly to make sure they stay in sync.
kylecarbs
approved these changes
Sep 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was annoyed by the Material UI warning I kept seeing in the console when running
yarn testso I decided to fix it based on this StackOverflow answer.Changes
See commits for descriptions