-
Notifications
You must be signed in to change notification settings - Fork 902
chore(site): fix material ui warning #4161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is the latest version which includes a fix for the warning we were seeing while running our tests about `css` function being deprecated.
`fade()` was deprecated in favor of `alpha()` in a previous version of `@material-ui/core/styles`.
This was deprecated in a previous version of `@material-ui/core`.
overlap="circle" was deprecated in favor of overlap="circular".
This was deprecated and changed to `createTheme`.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! That was bugging me, too.
Looks like there are some other changes I missed. Adding those now. |
I couldn't find any release notes or breaking changes related to this but it seems `props` can no longer be inferred on `SvgIcon`s so I had to manually add the type.
I'm not seeing these same errors locally when I run |
Hmm possibly a showstopper if this is true: mui/material-ui#33216 (comment) |
This reverts commit 94dae6f.
Unfortunately it looks stale. |
Looks like we may need to pass an empty object if some components in a file use `props` in styles and some don't.
We need to use generics so that `makeStyles` correctly infers the types for the `Pill.tsx` styles. I also updated the types to use `PillProps` directly to make sure they stay in sync.
I was annoyed by the Material UI warning I kept seeing in the console when running
yarn test
so I decided to fix it based on this StackOverflow answer.Changes
See commits for descriptions