Skip to content

feat: HA tailnet coordinator #4170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

feat: HA tailnet coordinator #4170

wants to merge 12 commits into from

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Sep 23, 2022

No description provided.

@coadler coadler self-assigned this Sep 23, 2022
@coadler coadler marked this pull request as ready for review September 23, 2022 18:27
@coadler coadler requested a review from kylecarbs September 23, 2022 18:27
"github.com/coder/coder/testutil"
)

func TestCoordinatorSingle(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think writing a benchmark would be helpful before merge. @johnstcn ran into some oddities with PostgreSQL pubsub performance, so we should ensure those limits aren't applicable here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this already works fine for v1 I think it would be good to find the limits for this later and recommend scaling in the docs.


t.Run("AgentWithoutClients", func(t *testing.T) {
t.Parallel()
coordinator, err := tailnet.NewHACoordinator(slogtest.Make(t, nil), database.NewPubsubInMemory())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably test this against multiple coordinators working together, otherwise it's not really replicating a deployment scenario.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the HA tests below

@coadler coadler requested a review from kylecarbs October 10, 2022 20:12
@github-actions
Copy link

github-actions bot commented Oct 12, 2022

CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅

@kylecarbs kylecarbs force-pushed the colin/pg-coordinate branch from a7f1727 to 5c43d63 Compare October 12, 2022 17:58
@coadler
Copy link
Contributor Author

coadler commented Oct 12, 2022

I have read the CLA Document and I hereby sign the CLA

@coadler
Copy link
Contributor Author

coadler commented Oct 12, 2022

recheck

@kylecarbs
Copy link
Member

This was merged in #3227

@kylecarbs kylecarbs closed this Oct 17, 2022
@kylecarbs kylecarbs deleted the colin/pg-coordinate branch October 17, 2022 19:48
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants