-
Notifications
You must be signed in to change notification settings - Fork 881
feat: HA tailnet coordinator #4170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
"github.com/coder/coder/testutil" | ||
) | ||
|
||
func TestCoordinatorSingle(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think writing a benchmark would be helpful before merge. @johnstcn ran into some oddities with PostgreSQL pubsub performance, so we should ensure those limits aren't applicable here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this already works fine for v1 I think it would be good to find the limits for this later and recommend scaling in the docs.
|
||
t.Run("AgentWithoutClients", func(t *testing.T) { | ||
t.Parallel() | ||
coordinator, err := tailnet.NewHACoordinator(slogtest.Make(t, nil), database.NewPubsubInMemory()) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should probably test this against multiple coordinators working together, otherwise it's not really replicating a deployment scenario.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the HA tests below
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
a7f1727
to
5c43d63
Compare
I have read the CLA Document and I hereby sign the CLA |
recheck |
This was merged in #3227 |
No description provided.