Skip to content

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 27, 2022

I was reading the docs for using the render function and noticed this:

Render into a container which is appended to document.body. It should be used with cleanup.

Since we're using a custom render I think it's expected we call cleanup after each test. After adding it, I noticed a significant number of act warnings disappear. It doesn't reduce all of them, but it's progress.

The remaining ones are mostly warnings related to submitForm and then an act warning in TemplatePage.test.tsx.

Related to #3626

@jsjoeio jsjoeio self-assigned this Sep 27, 2022
@jsjoeio jsjoeio marked this pull request as ready for review September 27, 2022 21:15
@jsjoeio jsjoeio requested a review from a team as a code owner September 27, 2022 21:15
@jsjoeio jsjoeio requested review from Kira-Pilot and removed request for a team September 27, 2022 21:15
Copy link
Member

@Kira-Pilot Kira-Pilot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@jsjoeio jsjoeio merged commit 9775228 into main Sep 27, 2022
@jsjoeio jsjoeio deleted the jsjoeio/fix-tests branch September 27, 2022 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants