Skip to content

chore(site): remove some eslint-disables #4265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 13, 2022
Merged

chore(site): remove some eslint-disables #4265

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ceda4ea
fix: await promises in WorkspacePage.test.tsx
jsjoeio Sep 29, 2022
3b280d4
chore: add eventsourcemock to cspell words
jsjoeio Sep 29, 2022
27be8c2
fix: clean up UsersPage.test.tsx
jsjoeio Sep 29, 2022
a4769d8
refactor: clean up eventsource mock
jsjoeio Sep 29, 2022
83e3583
revert: remove changes from WorkspacePage.test.tsx
jsjoeio Sep 29, 2022
5b4aa3a
Merge branch 'main' into jsjoeio/site-fixes
jsjoeio Oct 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: clean up UsersPage.test.tsx
  • Loading branch information
@jsjoeio
jsjoeio committed Sep 29, 2022
commit 27be8c2feb83fb17f55ee14ca8e296c26d34139a
4 changes: 1 addition & 3 deletions site/src/pages/UsersPage/UsersPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
/* eslint-disable @typescript-eslint/no-floating-promises */
import { fireEvent, screen, waitFor, within } from "@testing-library/react"
import userEvent from "@testing-library/user-event"
import { i18n } from "i18n"
Expand Down Expand Up @@ -474,8 +473,7 @@ describe("UsersPage", () => {
}),
)

// eslint-disable-next-line @typescript-eslint/no-empty-function
await updateUserRole(() => {}, MockAuditorRole)
await updateUserRole(() => null, MockAuditorRole)

// Check if the error message is displayed
const errorMessage = await screen.findByText("message from the backend")
Expand Down