Skip to content

feat: add rich parameters #4311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 18 commits into from
Closed

feat: add rich parameters #4311

wants to merge 18 commits into from

Conversation

kylecarbs
Copy link
Member

@kylecarbs kylecarbs commented Oct 2, 2022 •
edited
Loading

This adds support for a new coder_parameter type in Terraform which supports immutable, editable, and visually appealing parameters.

Examples:

image
image

Exposing the variable syntax in Terraform will become deprecated, and users will be forced to adopt the coder_parameter data source. Here's an example of the syntax:

data "coder_parameter" "example" {
  name = "Example"
  type = "string"
  option {
    name  = "First Option"
    value = "first"
  }
  option {
    name  = "Second Option"
    value = "second"
  }
}

Todo:

  • Update the create CLI to work with the new parameters.
  • Show a "deprecated" message in the UI with instructions to switch to new parameters.
  • Convert example templates to use the new parameter type.
  • Edit the "workspace create" UI to be prettier!

@kylecarbs kylecarbs self-assigned this Oct 2, 2022
@kylecarbs kylecarbs changed the title feat: Add coder_parameter type feat: Add coder_parameter data source for rich parameters Oct 2, 2022
@bpmct bpmct mentioned this pull request Oct 6, 2022
Closed
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Oct 12, 2022
@bpmct bpmct mentioned this pull request Oct 13, 2022
Closed
@github-actions github-actions bot closed this Oct 16, 2022
@kylecarbs kylecarbs reopened this Oct 25, 2022
@kylecarbs kylecarbs removed the stale This issue is like stale bread. label Oct 25, 2022
@kylecarbs
Copy link
Member Author

This PR has risen from the depths 👀

This was referenced Oct 25, 2022
Closed
Closed
@bpmct bpmct mentioned this pull request Nov 20, 2022
Closed
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Nov 27, 2022
@github-actions github-actions bot removed the stale This issue is like stale bread. label Dec 1, 2022
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Dec 10, 2022
@github-actions github-actions bot closed this Dec 13, 2022
@dcarrion87
Copy link
Contributor

Noooooo! I hope this is still a thing?

@onlycs
Copy link

onlycs commented Jan 2, 2023

@bpmct

@kylecarbs kylecarbs reopened this Jan 2, 2023
@kylecarbs
Copy link
Member Author

This is still a thing! Holiday stale bot!

@github-actions github-actions bot removed the stale This issue is like stale bread. label Jan 3, 2023
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 10, 2023
@ammario
Copy link
Member

ammario commented Jan 10, 2023

@mtojek — you're taking this now, right?

@ammario ammario changed the title feat: Add coder_parameter data source for rich parameters feat: add parameters v2 Jan 10, 2023
@ammario ammario mentioned this pull request Jan 10, 2023
Closed
@ammario ammario changed the title feat: add parameters v2 feat: add rich parameters Jan 10, 2023
@mtojek
Copy link
Member

mtojek commented Jan 10, 2023

@mtojek — you're taking this now, right?

Yes, once I'm done with the task I'm working on at the moment - #3522.

I haven't started this one, just skimmed through the PR to understand the scope. We have a call about it tomorrow.

@github-actions github-actions bot removed the stale This issue is like stale bread. label Jan 11, 2023
@mtojek mtojek mentioned this pull request Jan 16, 2023
Merged
@github-actions
Copy link

This Pull Request is becoming stale. In order to minimize WIP, prevent merge conflicts and keep the tracker readable, I'm going close to this PR in 3 days if there isn't more activity.

@github-actions github-actions bot added the stale This issue is like stale bread. label Jan 18, 2023
@github-actions github-actions bot closed this Jan 22, 2023
@dcarrion87
Copy link
Contributor

Bump for reopen.

@kylecarbs
Copy link
Member Author

@dcarrion87 this is being implemented in chunks now! Follow #5574 instead.

@github-actions github-actions bot deleted the parameter branch June 3, 2023 00:10
@matifali matifali mentioned this pull request Nov 6, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spikecurtis spikecurtis Awaiting requested review from spikecurtis spikecurtis will be requested when the pull request is marked ready for review spikecurtis is a code owner

@johnstcn johnstcn Awaiting requested review from johnstcn johnstcn will be requested when the pull request is marked ready for review johnstcn is a code owner

Assignees

@kylecarbs kylecarbs

Labels
stale This issue is like stale bread.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@kylecarbs @dcarrion87 @onlycs @ammario @mtojek