Skip to content

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 8, 2022
Merged

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart #4427

merged 2 commits into from
Oct 8, 2022

Conversation

andrei-nefeli
Copy link
Contributor

we have loadBalancerIP and externalTrafficPolicy in values, and service must have them too

@andrei-nefeli
loadBalancerIP and externalTrafficPolicy adding
7d4a4a2 
we have loadBalancerIP and externalTrafficPolicy in values, and service must have them too
@ammario ammario requested a review from deansheather October 8, 2022 19:34
deansheather
deansheather approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! 😄

@deansheather deansheather changed the title loadBalancerIP and externalTrafficPolicy adding fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart Oct 8, 2022
@deansheather deansheather enabled auto-merge (squash) October 8, 2022 21:08
@deansheather deansheather merged commit dd5173b into coder:main Oct 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrei-nefeli @deansheather