Skip to content

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart #4427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2022
Merged

fix: apply loadBalancerIP and externalTrafficPolicy values in helm chart #4427

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d4a4a2
loadBalancerIP and externalTrafficPolicy adding
andrei-nefeli Oct 7, 2022
7671eba
Apply suggestions from code review
deansheather Oct 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
loadBalancerIP and externalTrafficPolicy adding 
we have loadBalancerIP and externalTrafficPolicy in values, and service must have them too
  • Loading branch information
@andrei-nefeli
andrei-nefeli committed Oct 7, 2022
commit 7d4a4a247a22056859f9c7a73a8829c3aa79103c
8 changes: 8 additions & 0 deletions helm/templates/service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,14 @@ spec:
port: {{ include "coder.servicePort" . }}
targetPort: {{ include "coder.portName" . | quote }}
protocol: TCP
{{- if eq "LoadBalancer" .Values.coder.service.type }}
{{- with .Values.coder.service.loadBalancerIP }}
loadBalancerIP: {{ . }}
{{- end }}
{{- with .Values.coder.service.externalTrafficPolicy }}
externalTrafficPolicy: {{ . }}
{{- end }}
{{- end }}
selector:
{{- include "coder.selectorLabels" . | nindent 4 }}
{{- end }}