Show template average build #4545
Conversation
|
CLA Assistant Lite bot: I have read the CLA Document and I hereby sign the CLA 1 out of 2 committers have signed the CLA. |
|
I have read the CLA Document and I hereby sign the CLA |
| developerCount: (activeCount: number): string => { | ||
| return `${formatTemplateActiveDevelopers(activeCount)} developer${ | ||
| activeCount !== 1 ? "s" : "" | ||
| }` | ||
| }, | ||
| nameLabel: "Name", | ||
| buildTimeLabel: "Build time", |
There was a problem hiding this comment.
We'll want to move these in to a translation file - site/src/i18n/en/templatesPage.json will work fine.
You can look at this explanatory PR to see how how use translations in the component file.
There was a problem hiding this comment.
Where are these strings actually being used?
There was a problem hiding this comment.
This is all old code I haven't yet refactored. Will do the translations, thx.
There was a problem hiding this comment.
I think if we want to use translations across the board we should migrate everything in one fell swoop.
There was a problem hiding this comment.
I'm happy to handle that; maybe toward the end of next week.
There was a problem hiding this comment.
Up to you. I have no preference, except for consistency.
|
Continuing this here #4557 |
Continuing @iskhakovt's work from #3999