Skip to content

Support delete & stop transitions in build progress bar #4575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Oct 17, 2022
Merged

Support delete & stop transitions in build progress bar #4575

merged 11 commits into from
Oct 17, 2022

Conversation

ammario
Copy link
Member

@ammario ammario commented Oct 16, 2022

No description provided.

@ammario ammario requested a review from a team as a code owner October 16, 2022 20:36
@ammario ammario requested review from presleyp and removed request for a team October 16, 2022 20:36
@ammario ammario requested a review from kylecarbs October 16, 2022 22:14
kylecarbs
kylecarbs approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ammario ammario merged commit dc3519e into main Oct 17, 2022
@ammario ammario deleted the stop-progress branch October 17, 2022 04:34
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ammario @kylecarbs