Skip to content

fix: potential deadlock in coordinator #4598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 17, 2022
Merged

fix: potential deadlock in coordinator #4598

merged 1 commit into from
Oct 17, 2022

Conversation

sreya
Copy link
Collaborator

@sreya sreya commented Oct 17, 2022

No description provided.

@sreya sreya requested a review from kylecarbs October 17, 2022 19:32
kylecarbs
kylecarbs approved these changes Oct 17, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is soon getting a lot better tests

@sreya
Copy link
Collaborator Author

sreya commented Oct 17, 2022

Looks solid overall I was just taking a look, this seems like the type of thing we might be able to catch with a lint rule too

@sreya sreya enabled auto-merge (squash) October 17, 2022 19:38
@kylecarbs
Copy link
Member

This code doesn't have thorough enough tests for the impact IMO. Colin's tackling some updates here: #4578

@sreya sreya merged commit 9b4ab82 into main Oct 17, 2022
@sreya sreya deleted the jon/deadlock branch October 17, 2022 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sreya @kylecarbs