feat: Support x-forwarded-for headers for IPs #4684
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2410a20 to
d1c9711
Compare
jsjoeio
approved these changes
Oct 21, 2022
| @@ -321,6 +322,11 @@ func Server(dflags *codersdk.DeploymentFlags, newAPI func(context.Context, *code | |||
| } | |||
| } | |||
|
|
|||
| realIPConfig, err := httpmw.ParseRealIPConfig(dflags.ProxyTrustedHeaders.Value, dflags.ProxyTrustedOrigins.Value) | |||
| if err != nil { | |||
| return xerrors.Errorf("parse real ip config: %w", err) | |||
There was a problem hiding this comment.
nit: will a use know what real ip config means here? wondering if we can make that friendlier
coderd/httpmw/realip.go
Outdated
| headerXForwardedProto, | ||
| } | ||
|
|
||
| // Config configures the search order for the function, which controls |
There was a problem hiding this comment.
impressed with all the comments throughout this!
There was a problem hiding this comment.
Jonathan wrote this originally I believe :D
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4430.
This mostly copies in code from v1, and adds a few tests.