Skip to content

feat: add windows amd64 installer #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 25, 2022
Merged

feat: add windows amd64 installer #4719

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1ae6c47
feat: add windows installer
deansheather Oct 24, 2022
6989641
fix: remember windows install dir correctly
deansheather Oct 24, 2022
466b0d3
fix: install nsis in release CI
deansheather Oct 24, 2022
aa9af6a
chore: update nsis AddToPath implementation
deansheather Oct 24, 2022
a50376b
chore: tidy
deansheather Oct 24, 2022
e1718c9
chore: PR comments
deansheather Oct 24, 2022
46d855e
chore: PR comments
deansheather Oct 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: remember windows install dir correctly
  • Loading branch information
@deansheather
deansheather committed Oct 24, 2022
commit 69896417db3b12b71cbe1e8d99e8e0df02b7b721
3 changes: 2 additions & 1 deletion scripts/installer/installer.nsi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ Name "${APP_NAME}"
Caption "${APP_NAME}"
OutFile "${INSTALLER_NAME}"
BrandingText "${APP_NAME}"
InstallDirRegKey "${REG_ROOT}" "${REG_APP_PATH}" ""
InstallDirRegKey "${REG_ROOT}" "${REG_APP_PATH}" "Path"
InstallDir "${INSTALL_DIR}"

######################################################################
Expand Down Expand Up @@ -94,6 +94,7 @@ Section "Coder CLI" SecInstall
WriteUninstaller "$INSTDIR\uninstall.exe"

WriteRegStr ${REG_ROOT} "${REG_APP_PATH}" "" "$INSTDIR\${MAIN_APP_EXE_PATH}"
WriteRegStr ${REG_ROOT} "${REG_APP_PATH}" "Path" "$INSTDIR"
WriteRegStr ${REG_ROOT} "${UNINSTALL_PATH}" "DisplayName" "${APP_NAME}"
WriteRegStr ${REG_ROOT} "${UNINSTALL_PATH}" "UninstallString" "$INSTDIR\uninstall.exe"
WriteRegStr ${REG_ROOT} "${UNINSTALL_PATH}" "DisplayIcon" "$INSTDIR\${MAIN_APP_EXE_PATH}"
Expand Down