Skip to content

refactor: clean up WorkspaceBuildLogs types #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 25, 2022
Merged

refactor: clean up WorkspaceBuildLogs types #4738

merged 3 commits into from
Oct 25, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 24, 2022

  • refactor: clean up types in WorkspaceBuildLogs
  • feat: add tests for groupLogsByStage
  • fixup!: formatting

@jsjoeio jsjoeio changed the title jsjoeio/cleanup workspace build logs refactor: clean up WorkspaceBuildLogs types Oct 24, 2022
@jsjoeio jsjoeio self-assigned this Oct 24, 2022
@jsjoeio jsjoeio requested a review from BrunoQuaresma October 24, 2022 23:18
@jsjoeio jsjoeio marked this pull request as ready for review October 24, 2022 23:18
@jsjoeio jsjoeio requested a review from a team as a code owner October 24, 2022 23:18
@jsjoeio jsjoeio enabled auto-merge (squash) October 24, 2022 23:19
BrunoQuaresma
BrunoQuaresma approved these changes Oct 25, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@jsjoeio jsjoeio merged commit 49b3ea0 into main Oct 25, 2022
@jsjoeio jsjoeio deleted the jsjoeio/cleanup-workspace-build-logs branch October 25, 2022 00:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @BrunoQuaresma