Skip to content

refactor: clean up WorkspaceBuildLogs types #4738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 25, 2022
Merged

refactor: clean up WorkspaceBuildLogs types #4738

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d694a89
refactor: clean up types in WorkspaceBuildLogs
jsjoeio Oct 24, 2022
d9cdc85
feat: add tests for groupLogsByStage
jsjoeio Oct 24, 2022
2a76d55
fixup!: formatting
jsjoeio Oct 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fixup!: formatting
  • Loading branch information
@jsjoeio
jsjoeio committed Oct 24, 2022
commit 2a76d55d9fa34a8cebf50000b8d7b43a977f160c
11 changes: 5 additions & 6 deletions site/src/components/WorkspaceBuildLogs/WorkspaceBuildLogs.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ProvisionerJobLog } from "api/typesGenerated"
import { groupLogsByStage } from "./WorkspaceBuildLogs"

describe("groupLogsByStage", ()=> {
describe("groupLogsByStage", () => {
it("should group them by stage", () => {
const input: ProvisionerJobLog[] = [
{
Expand All @@ -10,25 +10,24 @@ describe("groupLogsByStage", ()=> {
log_source: "provisioner",
log_level: "debug",
stage: "build",
output: "test"
output: "test",
},
{
id: "2",
created_at: "oct 13",
log_source: "provisioner",
log_level: "debug",
stage: "cleanup",
output: "test"
output: "test",
},
{
id: "3",
created_at: "oct 13",
log_source: "provisioner",
log_level: "debug",
stage: "cleanup",
output: "done"
}

output: "done",
},
]

const actual = groupLogsByStage(input)
Expand Down