Skip to content

chore(site): enable eslint-plugin-eslint-comments #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 28, 2022
Merged

chore(site): enable eslint-plugin-eslint-comments #4799

merged 3 commits into from
Oct 28, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 28, 2022 •
edited
Loading

Per FE Variety, this adds a new ESLint plugin to enforce best practices around // eslint-disable comments.

See here: https://mysticatea.github.io/eslint-plugin-eslint-comments/

@jsjoeio jsjoeio self-assigned this Oct 28, 2022
@jsjoeio jsjoeio marked this pull request as ready for review October 28, 2022 19:49
@jsjoeio jsjoeio requested a review from a team as a code owner October 28, 2022 19:49
@jsjoeio jsjoeio requested review from BrunoQuaresma and removed request for a team October 28, 2022 19:49
@jsjoeio jsjoeio enabled auto-merge (squash) October 28, 2022 19:50
BrunoQuaresma
BrunoQuaresma approved these changes Oct 28, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Maybe, we should ignore this role for the typesGenerated file?

@jsjoeio jsjoeio merged commit ffe461a into main Oct 28, 2022
@jsjoeio jsjoeio deleted the jsjoeio/eslint-descriptions branch October 28, 2022 20:46
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2022
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Oct 28, 2022 •
edited
Loading

we should ignore this role for the typesGenerated file?

We could! Part of me was thinking a true solution would be to modify the types in the backend to not use any or use unknown instead. What do you think? 👀

I will keep that on my brain break list of TODOs!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees

@jsjoeio jsjoeio

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @BrunoQuaresma