Skip to content

chore(site): enable eslint-plugin-eslint-comments #4799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 28, 2022
Merged

chore(site): enable eslint-plugin-eslint-comments #4799

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f66fa0f
chore(site): enable eslint-plugin-eslint-comments
jsjoeio Oct 28, 2022
168760e
chore: add descriptions to eslint-disable comments
jsjoeio Oct 28, 2022
60772a2
chore: update eslint-disable comments in main.go
jsjoeio Oct 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
chore(site): enable eslint-plugin-eslint-comments
  • Loading branch information
@jsjoeio
jsjoeio committed Oct 28, 2022
commit f66fa0f4e69b07c7d308837f86ced55fe53ee48d
2 changes: 2 additions & 0 deletions site/.eslintrc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@ env:
extends:
- eslint:recommended
- plugin:@typescript-eslint/recommended
- plugin:eslint-comments/recommended
- plugin:import/recommended
- plugin:import/typescript
- plugin:react/recommended
Expand Down Expand Up @@ -60,6 +61,7 @@ rules:
"@typescript-eslint/triple-slash-reference": "off"
"brace-style": "off"
"curly": ["error", "all"]
"eslint-comments/require-description": "error"
eqeqeq: error
import/default: "off"
import/namespace: "off"
Expand Down
1 change: 1 addition & 0 deletions site/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,7 @@
"eslint-import-resolver-alias": "1.1.2",
"eslint-import-resolver-typescript": "3.5.0",
"eslint-plugin-compat": "4.0.2",
"eslint-plugin-eslint-comments": "^3.2.0",
"eslint-plugin-import": "2.26.0",
"eslint-plugin-jest": "27.0.1",
"eslint-plugin-jsx-a11y": "6.6.1",
Expand Down
10 changes: 9 additions & 1 deletion site/yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6346,6 +6346,14 @@ eslint-plugin-compat@4.0.2:
lodash.memoize "4.1.2"
semver "7.3.5"

eslint-plugin-eslint-comments@^3.2.0:
version "3.2.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-eslint-comments/-/eslint-plugin-eslint-comments-3.2.0.tgz#9e1cd7b4413526abb313933071d7aba05ca12ffa"
integrity sha512-0jkOl0hfojIHHmEHgmNdqv4fmh7300NdpA9FFpF7zaoLvB/QeXOGNLIo86oAveJFrfB1p05kC8hpEMHM8DwWVQ==
dependencies:
escape-string-regexp "^1.0.5"
ignore "^5.0.5"

eslint-plugin-import@2.26.0:
version "2.26.0"
resolved "https://registry.yarnpkg.com/eslint-plugin-import/-/eslint-plugin-import-2.26.0.tgz#f812dc47be4f2b72b478a021605a59fc6fe8b88b"
Expand Down Expand Up @@ -7762,7 +7770,7 @@ ignore@^4.0.3:
resolved "https://registry.yarnpkg.com/ignore/-/ignore-4.0.6.tgz#750e3db5862087b4737ebac8207ffd1ef27b25fc"
integrity sha512-cyFDKrqc/YdcWFniJhzI42+AzS+gNwmUzOSFcRCQYwySuBBBy/KjuxWLZ/FHEH6Moq1NizMOBWyTcv8O4OZIMg==

ignore@^5.2.0:
ignore@^5.0.5, ignore@^5.2.0:
version "5.2.0"
resolved "https://registry.yarnpkg.com/ignore/-/ignore-5.2.0.tgz#6d3bac8fa7fe0d45d9f9be7bac2fc279577e345a"
integrity sha512-CmxgYGiEPCLhfLnpPp1MoRmifwEIOgjcHXxOBjv7mY96c+eWScsOP9c112ZyLdWHi0FxHjI+4uVhKYp/gcdRmQ==
Expand Down