-
Notifications
You must be signed in to change notification settings - Fork 891
feat: show banner when workspace is outdated #4926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,58 @@ | ||
package cli | ||
|
||
import ( | ||
"net/url" | ||
"testing" | ||
|
||
"github.com/stretchr/testify/assert" | ||
"github.com/stretchr/testify/require" | ||
|
||
"github.com/coder/coder/codersdk" | ||
) | ||
|
||
const ( | ||
fakeOwnerName = "fake-owner-name" | ||
fakeServerURL = "https://fake-foo-url" | ||
fakeWorkspaceName = "fake-workspace-name" | ||
) | ||
|
||
func TestVerifyWorkspaceOutdated(t *testing.T) { | ||
t.Parallel() | ||
|
||
serverURL, err := url.Parse(fakeServerURL) | ||
require.NoError(t, err) | ||
|
||
client := codersdk.Client{URL: serverURL} | ||
|
||
t.Run("Up-to-date", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
workspace := codersdk.Workspace{Name: fakeWorkspaceName, OwnerName: fakeOwnerName} | ||
|
||
_, outdated := verifyWorkspaceOutdated(&client, workspace) | ||
|
||
assert.False(t, outdated, "workspace should be up-to-date") | ||
}) | ||
t.Run("Outdated", func(t *testing.T) { | ||
t.Parallel() | ||
|
||
workspace := codersdk.Workspace{Name: fakeWorkspaceName, OwnerName: fakeOwnerName, Outdated: true} | ||
|
||
updateWorkspaceBanner, outdated := verifyWorkspaceOutdated(&client, workspace) | ||
|
||
assert.True(t, outdated, "workspace should be outdated") | ||
assert.NotEmpty(t, updateWorkspaceBanner, "workspace banner should be present") | ||
}) | ||
} | ||
|
||
func TestBuildWorkspaceLink(t *testing.T) { | ||
t.Parallel() | ||
|
||
serverURL, err := url.Parse(fakeServerURL) | ||
require.NoError(t, err) | ||
|
||
workspace := codersdk.Workspace{Name: fakeWorkspaceName, OwnerName: fakeOwnerName} | ||
workspaceLink := buildWorkspaceLink(serverURL, workspace) | ||
|
||
assert.Equal(t, workspaceLink.String(), fakeServerURL+"/@"+fakeOwnerName+"/"+fakeWorkspaceName) | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I didn't look too closely at these tests on my first pass. I should point out that the preferred way to test in the
coder/coder
repo is write external tests (package cli_test
).With these types of tests, we'd do a bit more setup for the test so that we can then test the output of running
coder ssh ...
.(Not a blocker for this PR, but just a heads up for future PRs.)
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I see now. I can use existing coderdtest APIs. I need to create a workspace to simulate a template update (
CreateTemplateVersion
). Something likesetupWorkspaceForAgent
, but customized.I can adjust the implementation, but not sure if in this case the internal_test isn't just simpler (and shorter). Do you have any preference?