Skip to content

chore: refactor audit page to use window function for count #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Nov 21, 2022
Merged

chore: refactor audit page to use window function for count #5133

merged 15 commits into from
Nov 21, 2022

Conversation

presleyp
Copy link
Contributor

Refactor audit log page from having two endpoints to one endpoint that uses a window function.

@presleyp presleyp requested a review from a team as a code owner November 18, 2022 18:38
@presleyp presleyp requested review from BrunoQuaresma and removed request for a team November 18, 2022 18:38
BrunoQuaresma
BrunoQuaresma approved these changes Nov 19, 2022
View reviewed changes
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@presleyp presleyp merged commit 67941b4 into main Nov 21, 2022
@presleyp presleyp deleted the window-audit/presleyp branch November 21, 2022 16:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@BrunoQuaresma BrunoQuaresma BrunoQuaresma approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@presleyp @BrunoQuaresma