Skip to content

chore: refactor audit page to use window function for count #5133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Nov 21, 2022
Merged

chore: refactor audit page to use window function for count #5133

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
00342fb
Move count query to window function
presleyp Nov 15, 2022
31e8ae5
Unpack count and update types
presleyp Nov 15, 2022
2363361
Remove count endpoint
presleyp Nov 15, 2022
7363a70
Update tests, wip
presleyp Nov 16, 2022
04efd25
Fix tests
presleyp Nov 16, 2022
b40a80e
Update frontend, wip
presleyp Nov 16, 2022
1650803
Merge branch 'main' into window-audit/presleyp
presleyp Nov 16, 2022
fb46f46
Remove space
presleyp Nov 16, 2022
82d62c7
Fix frontend test
presleyp Nov 17, 2022
1797b58
Merge branch 'main' into window-audit/presleyp
presleyp Nov 17, 2022
0757395
Don't hang on error
presleyp Nov 18, 2022
eec1a61
Handle no results
presleyp Nov 18, 2022
0752245
Don't omit count
presleyp Nov 18, 2022
67d3944
Merge branch 'main' into window-audit/presleyp
presleyp Nov 18, 2022
8769f62
Fix frontend tests
presleyp Nov 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Handle no results
  • Loading branch information
@presleyp
presleyp committed Nov 18, 2022
commit eec1a6131b374517c46aa9cd62dd8cef229c3280
9 changes: 9 additions & 0 deletions coderd/audit.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,15 @@ func (api *API) auditLogs(rw http.ResponseWriter, r *http.Request) {
httpapi.InternalServerError(rw, err)
return
}
// GetAuditLogsOffset does not return ErrNoRows because it uses a window function to get the count.
// So we need to check if the dblogs is empty and return an empty array if so.
if len(dblogs) == 0 {
httpapi.Write(ctx, rw, http.StatusOK, codersdk.AuditLogResponse{
AuditLogs: []codersdk.AuditLog{},
Count: 0,
})
return
}

httpapi.Write(ctx, rw, http.StatusOK, codersdk.AuditLogResponse{
AuditLogs: convertAuditLogs(dblogs),
Expand Down