Skip to content

fix: Trigger workspace event after agent timeout seconds #5141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 22, 2022
Merged

fix: Trigger workspace event after agent timeout seconds #5141

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
da36b2b
fix: Trigger workspace even after agent timeout seconds
mafredri Nov 21, 2022
df7ced0
Update provisionerdserver.go
mafredri Nov 21, 2022
6d370ab
fix: PR comments
mafredri Nov 22, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: PR comments
  • Loading branch information
@mafredri
mafredri committed Nov 22, 2022
commit 6d370aba61c9bdc8e6c9c79d1be1011e44dd9168
3 changes: 1 addition & 2 deletions coderd/provisionerdserver/provisionerdserver.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,8 +675,7 @@ func (server *Server) CompleteJob(ctx context.Context, completed *proto.Complete
// after this function has returned. The server also doesn't
// have a shutdown signal we can listen to.
<-wait
err := server.Pubsub.Publish(codersdk.WorkspaceNotifyChannel(workspaceBuild.WorkspaceID), []byte{})
if err != nil {
if err := server.Pubsub.Publish(codersdk.WorkspaceNotifyChannel(workspaceBuild.WorkspaceID), []byte{}); err != nil {
server.Logger.Error(ctx, "workspace notification after agent timeout failed",
slog.F("workspace_build_id", workspaceBuild.ID),
slog.Error(err),
Expand Down