Skip to content

feat: add CODER_OIDC_IGNORE_EMAIL_VERIFIED config knob #5165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Nov 25, 2022
Merged

feat: add CODER_OIDC_IGNORE_EMAIL_VERIFIED config knob #5165

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d514764
feat: add CODER_OIDC_IGNORE_EMAIL_VERIFIED config knob
johnstcn Nov 21, 2022
dba4fa5
Update docs/admin/auth.md
johnstcn Nov 24, 2022
458a742
address PR comments and add test for OIDC defaults
johnstcn Nov 24, 2022
280619f
add warning message at startup if CODER_OIDC_IGNORE_EMAIL_VERIFIED=true
johnstcn Nov 24, 2022
521a74d
warn whenever an unverified OIDC email is let through based on config
johnstcn Nov 24, 2022
c491e79
add test for non-string value in OIDC claims
johnstcn Nov 24, 2022
d39d2ff
make gen
johnstcn Nov 24, 2022
e867027
skip flaky test on non-linux platforms
johnstcn Nov 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docs/admin/auth.md 
Co-authored-by: Mathias Fredriksson <mafredri@gmail.com>
  • Loading branch information
@johnstcn @mafredri
johnstcn and mafredri authored Nov 24, 2022
commit dba4fa5680a9e1af3ee8df1afa5cd314335eb207
2 changes: 1 addition & 1 deletion docs/admin/auth.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ CODER_TLS_CLIENT_KEY_FILE=/path/to/key.pem
```

Coder requires all OIDC email addresses to be verified by default. If the `email_verified` claim is present in the token response from the identity provider, Coder will validate that its value is `true`.
If you need to modify this behaviour, you can disable this behaviour like so:
If needed, you can disable this behavior with the following setting:

```console
CODER_OIDC_IGNORE_EMAIL_VERIFIED=true
Expand Down