Skip to content

feat: remove loadtest cmd, add new scaletest cmd #5310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 15, 2022
Merged

feat: remove loadtest cmd, add new scaletest cmd #5310

merged 7 commits into from
Dec 15, 2022

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Dec 6, 2022 •
edited
Loading

Closes #5202

TODO:

  • Implementation for coder scaletest cleanup
  • Tests for coder scaletest cleanup
  • Tests for coder scaletest createworkspaces
  • Tests for new createworkspace package

@deansheather deansheather marked this pull request as ready for review December 13, 2022 16:47
@deansheather deansheather requested a review from coadler December 13, 2022 16:47
coadler
coadler approved these changes Dec 14, 2022
View reviewed changes
cli/scaletest_test.go
)

func TestScaleTest(t *testing.T) {
t.Skipf("This test is flakey. See https://github.com/coder/coder/issues/4942")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still flakey?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably, it calls the flakey workspace build scale test :/

@deansheather deansheather enabled auto-merge (squash) December 15, 2022 14:58
@deansheather deansheather merged commit 6b6eac2 into main Dec 15, 2022
@deansheather deansheather deleted the dean/scaletest branch December 15, 2022 15:04
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@coadler coadler coadler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scaletest: use new format (no config file required)
2 participants
@deansheather @coadler