Skip to content

fix: Improve ptytest closure on expect match timeout #5337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 7, 2022
Merged

fix: Improve ptytest closure on expect match timeout #5337

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
07322d8
fix: Improve ptytest closure on expect match timeout
mafredri Dec 7, 2022
05b527b
chore: Clean up logging
mafredri Dec 7, 2022
dda5b2d
Use WaitShort
mafredri Dec 7, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Use WaitShort
  • Loading branch information
@mafredri
mafredri committed Dec 7, 2022
commit dda5b2d8d4dd7f2ed40ce113acb54608d26edf80
2 changes: 1 addition & 1 deletion pty/ptytest/ptytest.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ func create(t *testing.T, ptty pty.PTY, name string) *PTY {
}
// Set the actual close function for the tpty.
tpty.close = func(reason string) error {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitMedium)
ctx, cancel := context.WithTimeout(context.Background(), testutil.WaitShort)
defer cancel()

tpty.logf("closing tpty: %s", reason)
Expand Down