-
Notifications
You must be signed in to change notification settings - Fork 887
docs: make it clear the CLI must be downloaded to use templates #5373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor nits but thanks for putting together a page update!
We use console
to highlight a shell session command sequence as it looks to the user (with prompts, not just as the contents of a hypothetical script file). Otherwise, we should migrate to shell
, not sh
, each time we are in refactoring.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great! I just pushed a commit for fixing the dead URLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM :) Thanks Mark
34212b8
to
296349b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Second pass review
This PR is in response to Issue #5372 about making it clear that the CLI is the same binary as the server.
The PR also is making it clear how to use the CLI to build templates.