Skip to content

docs: make it clear the CLI must be downloaded to use templates #5373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Dec 13, 2022

Conversation

sharkymark
Copy link
Contributor

This PR is in response to Issue #5372 about making it clear that the CLI is the same binary as the server.

The PR also is making it clear how to use the CLI to build templates.

Copy link
Contributor

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits but thanks for putting together a page update!

We use console to highlight a shell session command sequence as it looks to the user (with prompts, not just as the contents of a hypothetical script file). Otherwise, we should migrate to shell, not sh, each time we are in refactoring.

@ghuntley ghuntley enabled auto-merge (squash) December 12, 2022 01:42
Copy link
Member

@ericpaulsen ericpaulsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great! I just pushed a commit for fixing the dead URLs.

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :) Thanks Mark

@ghuntley ghuntley disabled auto-merge December 13, 2022 19:17
Copy link
Contributor

@ghuntley ghuntley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second pass review

@ghuntley ghuntley enabled auto-merge (squash) December 13, 2022 19:28
@ghuntley ghuntley merged commit 8df02f4 into main Dec 13, 2022
@ghuntley ghuntley deleted the docs-cli-templates branch December 13, 2022 19:31
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants