Skip to content

fix(ci): fix winget installer workflow #5569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 5, 2023
Merged

fix(ci): fix winget installer workflow #5569

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f0b0d8a
fix(ci): add GH_TOKEN env
matifali Jan 4, 2023
dedff5e
fix(ci): change amd64 to win64 in windows installer
matifali Jan 4, 2023
70e62b7
chore: fix windows installer build filename
deansheather Jan 5, 2023
1348116
fixup! chore: fix windows installer build filename
deansheather Jan 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 16 additions & 5 deletions .github/workflows/packages.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,11 @@ jobs:
run: |
Invoke-WebRequest https://aka.ms/wingetcreate/latest -OutFile wingetcreate.exe

# the package version is the same as the release tag without the leading
# "v", and with a trailing ".0" (e.g. "v1.2.3" -> "1.2.3.0")
# The package version is the same as the tag minus the leading "v".
- name: Calculate package version
id: version
run: |
$version = $env:CODER_VERSION -replace "^v", ""
$version += ".0"
echo "::set-output name=version::$version"

- name: Submit updated manifest to winget-pkgs
Expand All @@ -35,17 +33,30 @@ jobs:

echo "Installer URL: $installer_url"

# The URL "|X64" suffix forces the architecture as it cannot be
# sniffed properly from the URL. wingetcreate checks both the URL and
# binary magic bytes for the architecture and they need to both match,
# but they only check for `x64`, `win64` and `_64` in the URL. Our URL
# contains `amd64` which doesn't match sadly.
#
# wingetcreate will still do the binary magic bytes check, so if we
# accidentally change the architecture of the installer, it will fail
# submission.
.\wingetcreate.exe update Coder.Coder `
--submit `
--version "${{ steps.version.outputs.version }}" `
--urls "$installer_url" `
--urls "${installer_url}|X64" `
--token "${{ secrets.CDRCI_GITHUB_TOKEN }}"

env:
# For gh CLI:
GH_TOKEN: ${{ github.token }}

- name: Comment on PR
run: |
# find the PR that wingetcreate just made
$pr_list = gh pr list --repo microsoft/winget-pkgs --search "author:cdrci Coder.Coder version ${{ steps.version.outputs.version }}" --limit 1 --json number | `
ConvertFrom-Json`
$pr_number = $pr_list[0].number

gh pr comment --repo microsoft/winget-pkgs "$pr_number" --body "🤖 cc: @deansheather"
gh pr comment --repo microsoft/winget-pkgs "$pr_number" --body "🤖 cc: @deansheather @matifali"