Skip to content

feat: add storybook for /deployment/gitauth #5596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2023
Merged

feat: add storybook for /deployment/gitauth #5596

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
50a537e
refactor: move GitAuthSettingsPage to dir
jsjoeio Jan 5, 2023
d1c2fb7
refactor: split page and view GitAuthSettingsPage
jsjoeio Jan 5, 2023
cffb9dd
fixup!: formatting
jsjoeio Jan 5, 2023
617cbf0
refactor: narrow props in git auth view
jsjoeio Jan 5, 2023
d778f31
feat: add storybook for GitAuthSettingsPageView
jsjoeio Jan 5, 2023
45a9d96
fixup: formatting
jsjoeio Jan 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion site/src/AppRouter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,10 @@ const UserAuthSettingsPage = lazy(
() => import("./pages/DeploySettingsPage/UserAuthSettingsPage"),
)
const GitAuthSettingsPage = lazy(
() => import("./pages/DeploySettingsPage/GitAuthSettingsPage"),
() =>
import(
"./pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage"
),
)
const NetworkSettingsPage = lazy(
() => import("./pages/DeploySettingsPage/NetworkSettingsPage"),
Expand Down
21 changes: 21 additions & 0 deletions site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { useDeploySettings } from "components/DeploySettingsLayout/DeploySettingsLayout"
import React from "react"
import { Helmet } from "react-helmet-async"
import { pageTitle } from "util/page"
import { GitAuthSettingsPageView } from "./GitAuthSettingsPageView"

const GitAuthSettingsPage: React.FC = () => {
const { deploymentConfig: deploymentConfig } = useDeploySettings()

return (
<>
<Helmet>
<title>{pageTitle("Git Authentication Settings")}</title>
</Helmet>

<GitAuthSettingsPageView deploymentConfig={deploymentConfig} />
</>
)
}

export default GitAuthSettingsPage
31 changes: 31 additions & 0 deletions site/src/pages/DeploySettingsPage/GitAuthSettingsPage/GitAuthSettingsPageView.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
import { ComponentMeta, Story } from "@storybook/react"
import {
GitAuthSettingsPageView,
GitAuthSettingsPageViewProps,
} from "./GitAuthSettingsPageView"

export default {
title: "pages/GitAuthSettingsPageView",
component: GitAuthSettingsPageView,
argTypes: {
deploymentConfig: {
defaultValue: {
gitauth: {
name: "Git Auth",
usage: "Automatically authenticate Git inside workspaces.",
value: [
{
id: "123",
client_id: "575",
},
],
},
},
},
},
} as ComponentMeta<typeof GitAuthSettingsPageView>

const Template: Story<GitAuthSettingsPageViewProps> = (args) => (
<GitAuthSettingsPageView {...args} />
)
export const Page = Template.bind({})
20 changes: 8 additions & 12 deletions ...eploySettingsPage/GitAuthSettingsPage.tsx → ...hSettingsPage/GitAuthSettingsPageView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,22 @@ import TableCell from "@material-ui/core/TableCell"
import TableContainer from "@material-ui/core/TableContainer"
import TableHead from "@material-ui/core/TableHead"
import TableRow from "@material-ui/core/TableRow"
import { DeploymentConfig } from "api/typesGenerated"
import { AlertBanner } from "components/AlertBanner/AlertBanner"
import { EnterpriseBadge } from "components/DeploySettingsLayout/Badges"
import { useDeploySettings } from "components/DeploySettingsLayout/DeploySettingsLayout"
import { Header } from "components/DeploySettingsLayout/Header"
import React from "react"
import { Helmet } from "react-helmet-async"
import { pageTitle } from "util/page"

const GitAuthSettingsPage: React.FC = () => {
export type GitAuthSettingsPageViewProps = {
deploymentConfig: Pick<DeploymentConfig, "gitauth">
}

export const GitAuthSettingsPageView = ({
deploymentConfig,
}: GitAuthSettingsPageViewProps): JSX.Element => {
const styles = useStyles()
const { deploymentConfig: deploymentConfig } = useDeploySettings()

return (
<>
<Helmet>
<title>{pageTitle("Git Authentication Settings")}</title>
</Helmet>

<Header
title="Git Authentication"
description="Coder integrates with GitHub, GitLab, BitBucket, and Azure Repos to authenticate developers with your Git provider."
Expand Down Expand Up @@ -105,5 +103,3 @@ const useStyles = makeStyles((theme) => ({
textAlign: "center",
},
}))

export default GitAuthSettingsPage