Skip to content

feat: Add basic support for rich parameters to coderd and provisionerd #5710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jan 17, 2023
Merged

feat: Add basic support for rich parameters to coderd and provisionerd #5710

merged 21 commits into from
Jan 17, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 13, 2023 •
edited
Loading

Related: #5574

This PR extracts basic support for rich parameters from #4311. So far, the feature should be accessible via direct interaction with API.
Both parameters, old and rich, should be working, but rich ones aren't exposed to the end user.

Follow-ups:
#5574 (comment)

@mtojek mtojek self-assigned this Jan 13, 2023
@mtojek mtojek mentioned this pull request Jan 13, 2023
Merged
@mtojek mtojek force-pushed the 5574-new-parameter-data-source branch from 774b80c to f228b34 Compare January 16, 2023 15:33
@mtojek mtojek changed the title feat: Support rich parameters for templates feat: Add basic support for rich parameters to coderd and provisionerd Jan 16, 2023
@mtojek mtojek mentioned this pull request Jan 16, 2023
Closed
@mtojek mtojek marked this pull request as ready for review January 16, 2023 17:31
@mtojek mtojek requested a review from a team as a code owner January 16, 2023 17:31
@mtojek mtojek requested review from presleyp and removed request for a team January 16, 2023 17:31
@mtojek mtojek requested a review from kylecarbs January 16, 2023 17:31
kylecarbs
kylecarbs approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Rich parameters is a nice name that doesn't make it super weird to interface with the API.

@mtojek mtojek merged commit 6ebadab into coder:main Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
Rich Parameters GA
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @kylecarbs @bpmct