Skip to content

feat: Expose workspace build parameters via API #5743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 17, 2023
Merged

feat: Expose workspace build parameters via API #5743

merged 1 commit into from
Jan 17, 2023

Conversation

mtojek
Copy link
Member

@mtojek mtojek commented Jan 17, 2023 •
edited
Loading

Related: #5574

Changes:

  • expose workspace build parameters via API (+ unit tests)
  • fix: workspace build parameters are set for workspace and workspacebuild flows

@mtojek mtojek self-assigned this Jan 17, 2023
@mtojek mtojek requested a review from kylecarbs January 17, 2023 14:52
@mtojek mtojek marked this pull request as ready for review January 17, 2023 14:52
@mtojek mtojek requested a review from a team as a code owner January 17, 2023 14:52
@mtojek mtojek requested review from presleyp and removed request for a team January 17, 2023 14:52
@mtojek mtojek mentioned this pull request Jan 17, 2023
Closed
kylecarbs
kylecarbs approved these changes Jan 17, 2023
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mtojek mtojek merged commit 1b0560c into coder:main Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2023
@bpmct bpmct added this to the Rich Parameters GA milestone Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@presleyp presleyp Awaiting requested review from presleyp presleyp was automatically assigned from coder/ts

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
Rich Parameters GA
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @kylecarbs @bpmct