feat: Support rich parameters in autobuilds #5916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
6fcf970 to
5954844
Compare
johnstcn
reviewed
Jan 30, 2023
| } | ||
| return nil | ||
|
|
||
| return store.InTx(func(db database.Store) error { |
There was a problem hiding this comment.
I'm not sure this is strictly necessary as each workspace is processed in its own transaction (see #L132)
There was a problem hiding this comment.
I'm rather thinking about the case when it inserts a record to the workspace table, but it fails to insert parameters for some reason. In this case, it's better to rollback the entire transaction.
johnstcn
approved these changes
Jan 30, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #5574
This PR enables support for rich parameters in autobuilds. I didn't notice that the build logic is duplicated.