feat!: generate a self-signed certificate if no certificates are specified #5973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fied Clouds like AWS automatically navigate to https://<ip-here>. This allows us to bind to that immediately, serve a self-signed certificate, then reroute to the access URL.
|
@deansheather Ben needs this to proceed with his work, so I'm going to merge this ASAP and do a release. If you see any issues, just let me know! |
bpmct
approved these changes
Feb 2, 2023
|
@kylecarbs what about if we do not use tls and use coder behind a reverse proxy like caddy? |
deansheather
approved these changes
Feb 2, 2023
cli/server.go
Outdated
Comment on lines
1248
to
1253
| var selfSignedCertificate *tls.Certificate | ||
| if len(certs) == 0 { | ||
| selfSignedCertificate, err = generateSelfSignedCertificate() | ||
| if err != nil { | ||
| return nil, xerrors.Errorf("generate self signed certificate: %w", err) | ||
| } |
There was a problem hiding this comment.
Why not just certs = append(certs, selfSignedCertificate) instead of the extra logic?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clouds like AWS automatically navigate to https://. This allows us to bind to that immediately, serve a self-signed certificate, then reroute to the access URL.
@deansheather I'm going to change the
tls-redirect-http-to-httpsflag toredirect-to-access-urlinstead.Edit: to automatically listen on 443 then redirect to the access URL:
This will still open the tunnel (because
access-urlis not set), prompt for a self-signed certificate, then redirect the user to our external tunnel.