Skip to content

feat!: generate a self-signed certificate if no certificates are specified #5973

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Feb 2, 2023
Merged

feat!: generate a self-signed certificate if no certificates are specified #5973

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1536b51
feat: generate a self-signed certificate if no certificates are speci…
kylecarbs Feb 2, 2023
beff932
Add new flag and deprecate old one
kylecarbs Feb 2, 2023
7cd5f2c
Fix redirect if not using tunnel
kylecarbs Feb 2, 2023
2a81e29
Add deprecation notice
kylecarbs Feb 2, 2023
596afcc
Fix TLS redirect
kylecarbs Feb 2, 2023
8336a07
Run `make gen`
kylecarbs Feb 2, 2023
b0adb77
Fix bad test
kylecarbs Feb 2, 2023
9ccdd59
Fix gen
kylecarbs Feb 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add deprecation notice
  • Loading branch information
@kylecarbs
kylecarbs committed Feb 2, 2023
commit 2a81e290571be5cbe0b068fd55d456452fd4a186
7 changes: 7 additions & 0 deletions cli/server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,13 @@ func Server(vip *viper.Viper, newAPI func(context.Context, *coderd.Options) (*co
return xerrors.New("tls address must be set if tls is enabled")
}

// DEPRECATED: This redirect used to default to true.
// It made more sense to have the redirect be opt-in.
if os.Getenv("CODER_TLS_REDIRECT_HTTP") == "true" || cmd.Flags().Changed("tls-redirect-http-to-https") {
cmd.PrintErr(cliui.Styles.Warn.Render("WARN:") + " --tls-redirect-http-to-https is deprecated, please use --redirect-to-access-url instead\n")
cfg.RedirectToAccessURL.Value = cfg.TLS.RedirectHTTP.Value
}

tlsConfig, err = configureTLS(
cfg.TLS.MinVersion.Value,
cfg.TLS.ClientAuth.Value,
Expand Down