helm: add deployment securityContext values #6136
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
approved these changes
Feb 9, 2023
deansheather
reviewed
Feb 9, 2023
deansheather
approved these changes
Feb 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds support for configuring the Coder deployment's
securityContext(for both pod & container) in the values file. this comes in handy when deploying Coder on OpenShift, which appliesSecurityContextConstraintsto deployments.one question i have - since the Coder deployment consists of a single container, is it necessary for us to have a pod-level
securityContext? thesecurityContextset at the container-level takes precedence over the pod-level context.keeping the
podSecurityContextvalues is beneficial if there is any possibility of us adding containers to the deployment. otherwise, I don't see much a reason to keep it.