Skip to content

refactor(site): Refactor template settings #6239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Feb 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

Before:
Screen Shot 2023-02-16 at 13 56 05

After:
Screen Shot 2023-02-16 at 13 56 13
Screen Shot 2023-02-16 at 13 56 25

@BrunoQuaresma BrunoQuaresma requested a review from a team February 16, 2023 16:58
@BrunoQuaresma BrunoQuaresma self-assigned this Feb 16, 2023
@BrunoQuaresma BrunoQuaresma requested review from Kira-Pilot and removed request for a team February 16, 2023 16:58
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bpmct could to review the UX + copy for this too?

@BrunoQuaresma
Copy link
Collaborator Author

The copy used is the same as the "Create template" page but feel free to suggest anything @bpmct

Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy LGTM

BrunoQuaresma and others added 2 commits February 16, 2023 14:24
Co-authored-by: Ben Potter <ben@coder.com>
Co-authored-by: Ben Potter <ben@coder.com>
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) February 17, 2023 12:35
@BrunoQuaresma BrunoQuaresma enabled auto-merge (squash) February 17, 2023 13:25
@BrunoQuaresma BrunoQuaresma merged commit 7a864bd into main Feb 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/refactor-template-settings branch February 17, 2023 13:27
@github-actions github-actions bot locked and limited conversation to collaborators Feb 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants