chore(helm): add unit tests for helm chart #6557
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Excited for this! |
You should try a nested go.mod file so any packages that import coder don't suffer. |
helm/tests/values_test.go
Outdated
| } | ||
|
|
||
| // Values is the top-level values struct for the Coder chart. | ||
| type Values struct { |
There was a problem hiding this comment.
Instead of having to maintain this type like we did in v1 (and forgot to do many times) can we just use map[string]any as the values type for test cases instead?
There was a problem hiding this comment.
Decided to go one level further and just run helm template instead; it's conceptually much simpler and removes the extra k8s API deps.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a minimum set of Helm tests for the Helm chart.
It's heavily based on the approach in enterprise-helm, but uses a golden-files-based approach instead.
It also runs
helm templatedirectly instead of importing the entire Kubernetes API.Golden files can be updated by running
go test ./helm/tests -updateor by runningmake update-golden-files.Fixes #6552