Skip to content

feat: Implement experiment gated CRUD for workspace proxies #6928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 26 commits into from
Apr 4, 2023
Merged

feat: Implement experiment gated CRUD for workspace proxies #6928

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
26 commits
Select commit Hold shift + click to select a range
243f837
feat: Implement basic moon crud
Emyrk Mar 30, 2023
5bd1392
chore: Implement enterprise endpoints for moons
Emyrk Mar 31, 2023
4b5e219
Make gen
Emyrk Mar 31, 2023
a593520
Add unit test for moons
Emyrk Mar 31, 2023
8613b13
Linting
Emyrk Mar 31, 2023
f1da2f1
Add url validation
Emyrk Mar 31, 2023
dff4fc8
Add unit tests
Emyrk Mar 31, 2023
aa41907
Make gen
Emyrk Mar 31, 2023
fa5ad31
Linting
Emyrk Mar 31, 2023
d4260b5
Fix unit test
Emyrk Mar 31, 2023
f689381
Fix unit test
Emyrk Mar 31, 2023
bace1cf
Make gen
Emyrk Apr 3, 2023
6ba9079
Merge remote-tracking branch 'origin/main' into stevenmasley/moon_crud
Emyrk Apr 3, 2023
a8a5be1
Bump migrations
Emyrk Apr 3, 2023
cce8a7d
wildcard hostname vs url
Emyrk Apr 4, 2023
d84b46c
Use tabs
Emyrk Apr 4, 2023
a1a31e4
Remove org scoped proxies
Emyrk Apr 4, 2023
440645c
Fix unit tests
Emyrk Apr 4, 2023
c7b6b7c
make fmt
Emyrk Apr 4, 2023
9824f2e
Fix route gen
Emyrk Apr 4, 2023
c7c52f3
Fix unit test
Emyrk Apr 4, 2023
0f3af22
Merge remote-tracking branch 'origin/main' into stevenmasley/moon_crud
Emyrk Apr 4, 2023
ac3f912
Merge remote-tracking branch 'origin/main' into stevenmasley/moon_crud
Emyrk Apr 4, 2023
3145d5f
Make gen
Emyrk Apr 4, 2023
8a5119e
Bump migrations
Emyrk Apr 4, 2023
7daf459
Only return non deleted
Emyrk Apr 4, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove org scoped proxies
  • Loading branch information
@Emyrk
Emyrk committed Apr 4, 2023
commit a1a31e46724ffb2ca9043a6a95ca7cd9576efe5e
149 changes: 67 additions & 82 deletions coderd/apidoc/docs.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

129 changes: 57 additions & 72 deletions coderd/apidoc/swagger.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions coderd/database/dbauthz/querier.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1685,16 +1685,18 @@ func (q *querier) GetWorkspaceByWorkspaceAppID(ctx context.Context, workspaceApp
return fetch(q.log, q.auth, q.db.GetWorkspaceByWorkspaceAppID)(ctx, workspaceAppID)
}

func (q *querier) GetWorkspaceProxies(ctx context.Context, organizationID uuid.UUID) ([]database.WorkspaceProxy, error) {
return fetchWithPostFilter(q.auth, q.db.GetWorkspaceProxies)(ctx, organizationID)
func (q *querier) GetWorkspaceProxies(ctx context.Context) ([]database.WorkspaceProxy, error) {
return fetchWithPostFilter(q.auth, func(ctx context.Context, _ interface{}) ([]database.WorkspaceProxy, error) {
return q.db.GetWorkspaceProxies(ctx)
})(ctx, nil)
}

func (q *querier) GetWorkspaceProxyByID(ctx context.Context, id uuid.UUID) (database.WorkspaceProxy, error) {
return fetch(q.log, q.auth, q.db.GetWorkspaceProxyByID)(ctx, id)
}

func (q *querier) InsertWorkspaceProxy(ctx context.Context, arg database.InsertWorkspaceProxyParams) (database.WorkspaceProxy, error) {
return insert(q.log, q.auth, rbac.ResourceWorkspaceProxy.InOrg(arg.OrganizationID), q.db.InsertWorkspaceProxy)(ctx, arg)
return insert(q.log, q.auth, rbac.ResourceWorkspaceProxy, q.db.InsertWorkspaceProxy)(ctx, arg)
}

func (q *querier) UpdateWorkspaceProxy(ctx context.Context, arg database.UpdateWorkspaceProxyParams) (database.WorkspaceProxy, error) {
Expand Down
10 changes: 3 additions & 7 deletions coderd/database/dbauthz/querier_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -464,13 +464,9 @@ func (s *MethodTestSuite) TestWorkspaceProxy() {
}).Asserts(p, rbac.ActionDelete)
}))
s.Run("GetWorkspaceProxies", s.Subtest(func(db database.Store, check *expects) {
p1 := dbgen.WorkspaceProxy(s.T(), db, database.WorkspaceProxy{
OrganizationID: uuid.New(),
})
p2 := dbgen.WorkspaceProxy(s.T(), db, database.WorkspaceProxy{
OrganizationID: p1.OrganizationID,
})
check.Args(p1.OrganizationID).Asserts(p1, rbac.ActionRead, p2, rbac.ActionRead).Returns(slice.New(p1, p2))
p1 := dbgen.WorkspaceProxy(s.T(), db, database.WorkspacseProxy{})
p2 := dbgen.WorkspaceProxy(s.T(), db, database.WorkspaceProxy{})
check.Args().Asserts(p1, rbac.ActionRead, p2, rbac.ActionRead).Returns(slice.New(p1, p2))
}))
}

Expand Down
9 changes: 3 additions & 6 deletions coderd/database/dbfake/databasefake.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4952,15 +4952,13 @@ func (q *fakeQuerier) UpdateWorkspaceAgentStartupLogOverflowByID(_ context.Conte
return sql.ErrNoRows
}

func (q *fakeQuerier) GetWorkspaceProxies(_ context.Context, organizationID uuid.UUID) ([]database.WorkspaceProxy, error) {
func (q *fakeQuerier) GetWorkspaceProxies(_ context.Context) ([]database.WorkspaceProxy, error) {
q.mutex.Lock()
defer q.mutex.Unlock()

cpy := make([]database.WorkspaceProxy, 0, len(q.workspaceProxies))
for _, p := range q.workspaceProxies {
if p.OrganizationID == organizationID && !p.Deleted {
cpy = append(cpy, p)
}
cpy = append(cpy, p)
}
return cpy, nil
}
Expand All @@ -4982,14 +4980,13 @@ func (q *fakeQuerier) InsertWorkspaceProxy(_ context.Context, arg database.Inser
defer q.mutex.Unlock()

for _, p := range q.workspaceProxies {
if !p.Deleted && p.OrganizationID == arg.OrganizationID && p.Name == arg.Name {
if !p.Deleted && p.Name == arg.Name {
return database.WorkspaceProxy{}, errDuplicateKey
}
}

p := database.WorkspaceProxy{
ID: arg.ID,
OrganizationID: arg.OrganizationID,
Name: arg.Name,
Icon: arg.Icon,
Url: arg.Url,
Expand Down
Loading