chore: move workspace apps tests to new package #7025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
reviewed
Apr 6, 2023
|
|
||
| // RunTests runs the entire workspace app test suite against deployments minted | ||
| // by the provided factory. | ||
| func RunTests(t *testing.T, factory DeploymentFactory) { |
There was a problem hiding this comment.
Because this is just used in workspaceapps_test.go and isn't tested independently, should it be it's own package?
I know it's large in size, but I might argue that it should be in the workspaceapps_test package instead, because that's what it's being used for anyways.
Regardless, we could call this Run instead, since test is in the package name.
There was a problem hiding this comment.
I think we can move it to workspaceapps pkg too.
Actually we cannot. You cannot import _test packages. So if we moved this to workspaceapps directory and workspaceapps_test package, then we cannot import it in our APGL and enterprise tests.
We will call this from the APGL and enterprise coderd tests.
Emyrk
approved these changes
Apr 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves almost every test from
workspaceapps_test.goand the reconnecting pty test to a new packagecoderd/workspaceapps/apptest.Closes #6905